Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore - clean up auto-generated files #2

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Chore - clean up auto-generated files #2

merged 2 commits into from
Sep 12, 2022

Conversation

jcarpe
Copy link
Member

@jcarpe jcarpe commented Sep 7, 2022

Description

  • delete auto-gen php errors log
  • add auto-gen file to .gitignore

Notes / Questions

  • Could we update the readme file to have clearer usage & intent for this repository?
  • It feels like this is a bit of a monolith encompassing; the website, examples, useable JS modules, & more (?)

@jcarpe jcarpe changed the base branch from d3 to main September 12, 2022 17:32
@zoltan-dulac zoltan-dulac merged commit aa98ac4 into PublicisSapient:main Sep 12, 2022
@jcarpe jcarpe deleted the chore/clean-up-autogen-files branch September 13, 2022 03:06
ocjadan added a commit that referenced this pull request Jun 20, 2024
@ocjadan
Step #2 instructions change: explicitly state data-has-character-coun…
2e86109 
…t attribute instead of hasCharacterCount.
@zoltan-dulac zoltan-dulac mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcarpe @zoltan-dulac