Skip to content

Commit

Permalink
Merge branch '89-vd-change-form-error-checking-page' of https://githu…
Browse files Browse the repository at this point in the history
…b.com/PublicisSapient/enable-a11y into 89-vd-change-form-error-checking-page
  • Loading branch information
Neha-Singla committed Jun 6, 2024
2 parents 4739fb3 + d738a6b commit 49b87fa
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 1 deletion.
31 changes: 31 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,35 @@ A place to learn and share with developers what makes web work accessible. This
- You can find the path to the installed PHP using `which php`. Add that path to your terminal profile's PATH environment value and/or VS Code settings.
- Java: required in order to use the v.Nu checker during automation and unit testing

- Install options:

- Brew Install Options:

- ```bash
brew install java
```
- ```bash
brew install openjdk
```
- Additional tasks

- ```bash
java -version
```

If you get "Unable to locate a Java Runtime", proceed to next step.

- Ensure your symlink is correctly mapped (these instructions will also appear after you brew install java)

- ```bash
sudo ln -sfn /opt/homebrew/opt/openjdk/libexec/openjdk.jdk \
/Library/Java/JavaVirtualMachines/openjdk.jdk
```

- Manual Install Options:
- Mac Install <https://www.java.com/en/download/help/mac_install.html>
- Windows Install <https://www.java.com/en/download/help/windows_manual_download.html>

> Note: Any changes to these prerequisites will need to be reflected in the GitHub Actions in order to run the CI/CD checks.

#### Optional installations (since `npm run server` will run an express server)
Expand Down Expand Up @@ -59,6 +88,8 @@ A place to learn and share with developers what makes web work accessible. This

> See the [Chromedriver issues](#chromedriver-issues) section if you encounter an error related to Chromedriver.

> Make sure your local server is running in another terminal before running `npm run test`.

## Tests

### Tools used for testing
Expand Down
5 changes: 4 additions & 1 deletion bin/php-express/lib/PHPExpress/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ var PHPExpress = function (opts) {
console.log(`Error was: ${error || stderr}`)
process.exit(1);
} else {
this.binPath = stdout.trim();
const stdoutVal = stdout.trim();
if (stdoutVal !== '') {
this.binPath = stdoutVal;
}
console.log(`PHP found at ${this.binPath}`);
}
});
Expand Down

0 comments on commit 49b87fa

Please sign in to comment.