Generate API on STDOUT when single target framework given #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
changed the title
Just one note. I have one project (assembly) for which public API is generated in more than 50 seconds. |
|
I think I'll set the default timeout to 60 seconds and make it configurable as part of the minor. Will do after the weekend -------- Ursprüngliche Nachricht --------Von: Ivan Maximov <notifications@github.com>Datum: Sa., 1. Feb. 2020, 07:47An: PublicApiGenerator/PublicApiGenerator <PublicApiGenerator@noreply.github.com>Cc: Daniel Marbach <daniel.marbach@openplace.net>, State change <state_change@noreply.github.com>Betreff: Re: [PublicApiGenerator/PublicApiGenerator] Generate API on STDOUT when single target framework given (#181)
If dotnet run times out (after 10 seconds, which seems short to be honest) then an exception is thrown.
Just one note. I have one project (assembly) for which public API is generated in more than 50 seconds.
—You are receiving this because you modified the open/close state.Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #173.
Replaces #180
Notable Changes
The worker project's
Program.Maintakes two parameters only: the source assembly path and the output API file path. If the latter is-then the API is generated to standard output. It also logs unhandled exceptions to standard error and sets an exit code on success or failure. It is no longer the responsibility of the worker project to do any file operations like deleting and moving. This is done by PublicApiGenerator.If
dotnet runtimes out (after 10 seconds, which seems short to be honest) then an exception is thrown. Previously, PublicApiGenerator continue silently.