[Leo] Add hexadecimal, octal, binary numerals. #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on discussion at Leo sync.
bendyarm
reviewed
Oct 21, 2024
bendyarm
reviewed
Oct 21, 2024
bendyarm
reviewed
Oct 21, 2024
bendyarm
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Added some suggested changes.
Also we should think more about how to handle negative literals such as i8
and field and scalar and maybe group (group coordinate has a literal "-", is group coordinate still used?).
If we are handling them as unary minus operator, it looks to me like the grammar doesn't support that.
Co-authored-by: Eric McCarthy <7607035+bendyarm@users.noreply.github.com> Signed-off-by: Alessandro Coglio <2409151+acoglio@users.noreply.github.com>
Co-authored-by: Eric McCarthy <7607035+bendyarm@users.noreply.github.com> Signed-off-by: Alessandro Coglio <2409151+acoglio@users.noreply.github.com>
Co-authored-by: Eric McCarthy <7607035+bendyarm@users.noreply.github.com> Signed-off-by: Alessandro Coglio <2409151+acoglio@users.noreply.github.com>
|
Group coordinates are still in use. |
bendyarm
reviewed
Oct 21, 2024
| @@ -375,7 +394,8 @@ unary-expression = postfix-expression | |||
| / "!" unary-expression | |||
| / "-" unary-expression | |||
|
|
|||
| cast-expression = unary-expression %s"as" named-primitive-type | |||
| cast-expression = unary-expression | |||
There was a problem hiding this comment.
Just curious; was cast-expression previously not including a plain unary-expression alternative just an oversight?
There was a problem hiding this comment.
Yes, an oversight indeed. It was not following the same hierarchical pattern as the other kinds of expressions.
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes all the usual ACL2 checks.