Mention web components, support for the shadow DOM root node on the f… #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ront page. Because it's awesome shit
|
I am not quite sure what you are referring to here. Just that the editor doesn't break entirely when used in a shadow DOM? I'd consider that kind of baseline functionality, and we're not even there yet on Safari (though that's more of a Safari bug and not really something we can help, see ProseMirror/prosemirror#476). |
|
Yeah I just got a little excited, HTML import, template, custom elements all seemed to jive when I put pm inside my own component. So when you added support for the shadow root I figured that was something to advertise. But yeah I didn't see anything break using chrome of course. I haven't tested safari. My bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ront page. Because it's awesome shit.
Marijn feel free to ignore this or edit the description but I thought this needs more attention. I've noticed you requested assistance on the website, I'll go and check the details in that thread now.
However today after adding custom element support (with shadow DOM) to my code I figured this feature needs a big mention