Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chrome browser check #10

Closed
wants to merge 1 commit into from
Closed

Add chrome browser check #10

wants to merge 1 commit into from

Conversation

bedeoverend
Copy link
Contributor

Adds in a chrome property to the browsers file. This allows the selection bug check which was added to fix Shadow DOM failing in chrome

@bedeoverend
Copy link
Contributor Author

Not sure about the User-Agent string check on this. Just an assumption that /Chrome/ would be enough

@marijnh
Copy link
Member

marijnh commented Apr 13, 2017

Oops, I pushed 931e286 before I saw this. That one also makes sure there's a slash after Chrome to avoid false positives for user agent strings that randomly throw the word Chrome in there.

@marijnh marijnh closed this Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken in Shadow DOM
2 participants
@bedeoverend @marijnh