Skip to content

Commit

Permalink
Enforce min version of w3c-keyname to be 1.1.8
Browse files Browse the repository at this point in the history
Version below 1.1.8 has an issue when shortcuts with the Shift key
(e.g. CMD+Shift+Z) is not working properly in Chrome (maybe other
browsers too).

It's happening because w3c-keyname returns z (as a lowercase z)
instead of Z (uppercase Z) which is breaking those shortcuts.

Even though version 1.1.8 satisfies specified semver range of '^1.1.0'
tooling like yarn is not updating existing yarn locks... Solution
could be to manually amend yarn.lock/package-lock.json, but I think it
makes total sense to just force it in a package...

FIX: Upgrade `w3c-keyname` dependency to version 1.1.8 to prevent
users getting stuck with a buggy version.

Issue #1
  • Loading branch information
d4rkr00t authored and marijnh committed Feb 23, 2018
1 parent b44e43d commit 0ccd938
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"url": "git://github.com/prosemirror/prosemirror-keymap.git"
},
"dependencies": {
"w3c-keyname": "^1.1.0",
"w3c-keyname": "^1.1.8",
"prosemirror-state": "^1.0.0"
},
"devDependencies": {
Expand Down

0 comments on commit 0ccd938

Please sign in to comment.