Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MultiCoil #40

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Implement MultiCoil #40

merged 2 commits into from
Aug 9, 2024

Conversation

bclyons12
Copy link
Member

This creates a new MultiCoil that contains a collection of coils assumed to be connected in series. It also creates a new type AbstractSingleType which is a subtype of AbstractType.

@bclyons12 bclyons12 added the enhancement New feature or request label Aug 9, 2024
@bclyons12 bclyons12 requested a review from orso82 August 9, 2024 21:01
@bclyons12 bclyons12 self-assigned this Aug 9, 2024
@bclyons12
Copy link
Member Author

@orso82 Technically this is a breaking change, since AbstractCoil is now a supertype of the new AbstractSingleCoil. AbstractSingleCoil now acts like AbstractCoil used to (with typing and such). If someone had something like AbstractCoil{T1,T2,T3,T4} in their code, then this would break. That said, nothing uses this outside of VacuumFields right now. I'd propose a minor version bump, not a full major release.

@bclyons12 bclyons12 merged commit 272252d into master Aug 9, 2024
2 checks passed
@bclyons12 bclyons12 deleted the multicoil branch August 9, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant