Fix large allocations

Mention @TimSlendebroek @bclyons12
ProjectTorreyPines · Sep 21, 2022 · ec07e3d · ec07e3d · bclyons12 · Sep 21, 2022
1 parent 4dcc4c4
commit ec07e3d
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/coil_currents.jl b/src/coil_currents.jl
@@ -601,18 +601,18 @@ function halfhull(points::Vector{Point})
     halfhull = points[1:2]
     for p in points[3:end]
         push!(halfhull, p)
-        while length(halfhull) > 2 && !isrightturn(halfhull[end-2:end]...)
+        while length(halfhull) > 2 && !isrightturn(halfhull[end-2], halfhull[end-1], halfhull[end])
             deleteat!(halfhull, length(halfhull) - 1)
         end
     end
     return halfhull
 end
 
 function grahamscan(points::Vector{Point})
-    sorted = sort(points)
-    upperhull = halfhull(sorted)
-    lowerhull = halfhull(reverse(sorted))
-    return Point[upperhull..., lowerhull[2:end-1]...]
+    sort!(points)
+    upperhull = halfhull(points)
+    lowerhull = halfhull(reverse!(points))
+    return Point[upperhull; lowerhull[2:end-1]]
 end
 
 function convex_hull(xy_points::Vector{Point}; closed_polygon::Bool)