Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in metadata links not having target="_blank" #1229

Merged
merged 5 commits into from
Jan 11, 2017
Merged

Fix in metadata links not having target="_blank" #1229

merged 5 commits into from
Jan 11, 2017

Conversation

morpheus-87
Copy link
Contributor

This PR adds the functionality, that HMTL links in the metadata are extended with the attribute target and the value _blank.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 61.439% when pulling ac21ab8 on dbmdz:fix/metadata-link-target into 128b479 on ProjectMirador:2.1.3.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 61.439% when pulling ab4de34 on dbmdz:fix/metadata-link-target into b8ff140 on ProjectMirador:2.1.3.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 61.786% when pulling 4492c0a on dbmdz:fix/metadata-link-target into bc7c3e9 on ProjectMirador:2.1.3.

@rsinghal rsinghal merged commit b4248b4 into ProjectMirador:2.1.3 Jan 11, 2017
@morpheus-87 morpheus-87 deleted the fix/metadata-link-target branch January 12, 2017 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsinghal rsinghal rsinghal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morpheus-87 @coveralls @rsinghal