content/issue 75 final content and site review #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
enhancement
✅ Deploy Preview for super-tapioca-5987ce ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thescientist13
added
docs
Closed
DevLab2425
reviewed
Nov 7, 2024
|
|
||
| links.forEach((link) => { | ||
| if (!route.startsWith("/blog/") && link.getAttribute("href").startsWith("/")) { | ||
| const linkUrl = new URL(`https://www.greenwoodjs.dev${link.getAttribute("href")}`); |
There was a problem hiding this comment.
Nit pick.. the URL() class can take 2 arguments, which would avoid the string concat.
Suggested change
| const linkUrl = new URL(`https://www.greenwoodjs.dev${link.getAttribute("href")}`); | |
| const linkUrl = new URL(link.getAttribute("href"), 'https://www.greenwoodjs.dev'); |
https://developer.mozilla.org/en-US/docs/Web/API/URL/URL#parameters
There was a problem hiding this comment.
Oh right, I always forget about that lol. Next time! (Or happy to accept a PR for it 👍)
thescientist13
deleted the
content/issue-75-final-content-and-site-review
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #75
Summary of Changes
TODO