Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/Issue-119: Setup project with Stylelint a11y plugin #121

Merged
merged 8 commits into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
289 changes: 212 additions & 77 deletions package-lock.json

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"@babel/eslint-parser": "^7.25.7",
"@babel/plugin-syntax-import-assertions": "^7.25.7",
"@chromatic-com/storybook": "^1.3.1",
"@double-great/stylelint-a11y": "^3.0.2",
"@eslint/js": "^9.11.1",
"@eslint/json": "^0.5.0",
"@eslint/markdown": "^6.2.0",
Expand Down Expand Up @@ -73,7 +74,7 @@
"rimraf": "^5.0.5",
"storybook": "^8.0.6",
"storybook-addon-fetch-mock": "^2.0.1",
"stylelint": "^16.4.0",
"stylelint": "^16.10.0",
"stylelint-config-recommended": "^14.0.1",
"vite": "^5.2.8"
},
Expand Down
3 changes: 2 additions & 1 deletion src/components/blog-posts-list/blog-posts-list.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
text-decoration: none;
}

.postsListItemContentLink:hover {
.postsListItemContentLink:hover,
.postsListItemContentLink:focus {
text-decoration: none;
}

Expand Down
9 changes: 6 additions & 3 deletions src/components/capabilities/capabilities.css
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@
stroke: var(--color-gray);
}

.section:hover {
.section:hover,
.section:focus {
border: 2px dotted var(--color-accent);
}

.active strong,
.section:hover strong {
.section:hover strong,
.section:focus strong {
font-family: var(--font-primary-bold);
color: var(--color-white);
}
Expand Down Expand Up @@ -117,7 +119,8 @@ pre {
margin-right: var(--size-px-4);
}

.section:hover {
.section:hover,
.section:focus {
padding: var(--size-px-2);
}
}
Expand Down
6 changes: 4 additions & 2 deletions src/components/get-started/get-started.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,15 @@
text-decoration: none;
}

.buttonBlitz:hover {
.buttonBlitz:hover,
.buttonBlitz:focus {
background-color: var(--color-gray);
text-decoration: none;
color: var(--color-black) !important;
}

.buttonStarted:hover {
.buttonStarted:hover,
.buttonStarted:focus {
background-color: var(--color-accent);
text-decoration: none;
color: var(--color-black) !important;
Expand Down
3 changes: 2 additions & 1 deletion src/components/header/header.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
text-decoration: none;
}

.navBarMenuItem a:hover {
.navBarMenuItem a:hover,
.navBarMenuItem a:focus {
text-decoration: underline;
}

Expand Down
6 changes: 4 additions & 2 deletions src/components/hero-banner/hero-banner.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,15 @@
text-decoration: none;
}

.buttonBlitz:hover {
.buttonBlitz:hover,
.buttonBlitz:focus {
background-color: var(--color-secondary);
color: var(--color-white) !important;
text-decoration: none;
}

.buttonStarted:hover {
.buttonStarted:hover,
.buttonStarted:focus {
background-color: var(--color-accent);
text-decoration: none;
color: var(--color-black) !important;
Expand Down
3 changes: 2 additions & 1 deletion src/components/run-anywhere/run-anywhere.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
color: var(--color-white);
}

.platformBox a:hover {
.platformBox a:hover,
.platformBox a:focus {
color: var(--color-black);
background-color: var(--color-white);
text-decoration: none;
Expand Down
14 changes: 9 additions & 5 deletions src/components/side-nav/side-nav.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,11 @@
box-shadow: var(--shadow-3);
color: var(--color-black);

& #indicator {
display: inline-block;
transition: transform 1s ease;
@media (prefers-reduced-motion: no-preference) {
& #indicator {
display: inline-block;
transition: transform 1s ease;
}
}
}

Expand Down Expand Up @@ -71,7 +73,8 @@
}

& a.active,
& a:hover {
& a:hover,
& a:focus {
text-decoration: underline;
opacity: 0.7;
}
Expand All @@ -85,7 +88,8 @@
list-style: none;
margin: 0 0 var(--size-6) 0;

& a:hover {
& a:hover,
& a:focus {
opacity: 0.7;
}
}
Expand Down
11 changes: 7 additions & 4 deletions src/components/table-of-contents/table-of-contents.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,11 @@
border-radius: var(--radius-2);
box-shadow: var(--shadow-3);

& #indicator {
display: inline-block;
transition: transform 1s ease;
@media (prefers-reduced-motion: no-preference) {
& #indicator {
display: inline-block;
transition: transform 1s ease;
}
}
}

Expand Down Expand Up @@ -89,7 +91,8 @@
font-size: var(--font-size-1);
}

& a:hover {
& a:hover,
& a:focus {
opacity: 0.7;
}
}
Expand Down
8 changes: 6 additions & 2 deletions src/styles/theme.css
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ a:visited {
color: var(--color-primary);
}

a:hover {
a:hover,
a:focus {
text-decoration: underline;
background-color: transparent;
}
Expand Down Expand Up @@ -120,8 +121,11 @@ h4 > a > span.icon {
}

h2:hover > a > span.icon,
h2:focus > a > span.icon,
h3:hover > a > span.icon,
h4:hover > a > span.icon {
h3:focus > a > span.icon,
h4:hover > a > span.icon,
h4:focus > a > span.icon {
opacity: 1;
}

Expand Down
6 changes: 6 additions & 0 deletions stylelint.config.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
export default {
extends: ["stylelint-config-recommended"],
plugins: ["@double-great/stylelint-a11y"], // -> no `extends` https://github.com/double-great/stylelint-a11y/issues/65
rules: {
"a11y/media-prefers-reduced-motion": true,
"a11y/no-outline-none": true,
"a11y/selector-pseudo-class-focus": true,
},
};