Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-79: Recreate the json.svg to better align #108

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

DevLab2425
Copy link
Contributor

Related Issue

Fix #79

Summary of Changes

  • Recreated the json.svg to enlarge the curly braces and center them in the surrounding rectangle
  • Update capabilities component to utilize the json.svg
  • Include a new API Routes button within capabilities storybook

Screenshots

Home page
Screen Shot 2024-10-10 at 17 16 30

Storybook
Screen Shot 2024-10-10 at 17 33 59

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit 2337b86
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/6709471c38de59000876e49a
😎 Deploy Preview https://deploy-preview-108--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 added the enhancement New feature or request label Oct 10, 2024
Copy link
Member

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heck yeah, this is perfect!

Aside from the little formatting comment I left, we can delete the api-routes.svg file.

@@ -49,7 +49,32 @@ const Template = () => `

customElements.define("app-card", Card);
</pre>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the formatting is off a bit here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Updated.

@DevLab2425 DevLab2425 merged commit b12cc79 into main Oct 11, 2024
5 checks passed
@DevLab2425 DevLab2425 deleted the issue-79-api-routes-svg-enhance branch October 11, 2024 15:42
@DevLab2425 DevLab2425 added the hacktoberfest-accepted Used to participate in Hacktoberfest label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest-accepted Used to participate in Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use curly braces ({ }) as the icon for API Routes in the "capabilities" section of the home page
2 participants