Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/issue 763 restore postcss import #998

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 12, 2022

Related Issue

related to #763

From downstream testing, I think it makes sense, especially for CSS-in-JS, we would want to retain postcss-import

Summary of Changes

  1. Restore postcss-plugin as default in PostCSS plugin
  2. Update documenation

TODO

  1. add test case (nice to have)

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins alpha.4 v0.27.0 labels Nov 12, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 12, 2022
@thescientist13 thescientist13 changed the base branch from master to release/0.27.0 November 12, 2022 21:40
@thescientist13 thescientist13 force-pushed the enhancement/issue-763-restore-postcss-import branch from 12a7f75 to 2630440 Compare November 18, 2022 01:50
@thescientist13 thescientist13 merged commit 992e180 into release/0.27.0 Nov 18, 2022
@thescientist13 thescientist13 deleted the enhancement/issue-763-restore-postcss-import branch November 18, 2022 02:02
thescientist13 added a commit that referenced this pull request Nov 18, 2022
thescientist13 added a commit that referenced this pull request Nov 18, 2022
thescientist13 added a commit that referenced this pull request Nov 23, 2022
* restore postcss-import to postcss plugin default config

* document postcss-import in default postcss-plugin config

* update test case

* update spec
thescientist13 added a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.4 enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins v0.27.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant