Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure SPA does not prerender by default #891

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Feb 17, 2022

Related Issue

resolves #890

Summary of Changes

  1. Handle SPA prerender setting when no greenwood.config.js is present

@thescientist13 thescientist13 added bug Something isn't working CLI labels Feb 17, 2022
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label Feb 19, 2022
@thescientist13 thescientist13 force-pushed the bug/issue-890-spa-prerenders-by-default branch from eccdffa to 66a159c Compare February 24, 2022 02:20
@thescientist13
Copy link
Member Author

Probably maybe we should increase the test timeouts overall? Seems Windows always has a little trouble and the when a server based test fails, it usually leave the dev server still running, which causes subsequent tests to usually fail due to the port still being in use.

@thescientist13 thescientist13 merged commit b58e617 into master Feb 24, 2022
@thescientist13 thescientist13 deleted the bug/issue-890-spa-prerenders-by-default branch February 24, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPA prerenders by default when no _greenwood.config.js_ is present
1 participant