Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/include resource tracking and serialization for all pages #1100

Merged
merged 7 commits into from
May 6, 2023

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Apr 15, 2023

Related Issue

resolves #1098

Summary of Changes

  1. Ended up being a bit of a refactor to make sure all pages had their resources tracked, not just the prerendered one
  2. Re-serialize graph.json to include page resources and frontmatter imports and delete graph copy plugin
  3. Add specs to cover SSR pages get properly bundled assets

TODO

  1. Add test case
  2. Try and keep graph.json light weight (maybe try and re-hydrate graph.json from resources.json)
  3. track refactoring opportunities into a new or existing issue
  4. Handle those 500s as 404s instead (nice to have, otherwise make a ticket) - not found static assets are returning 500 status code when running the serve command #1102

@thescientist13 thescientist13 added bug Something isn't working CLI SSR labels Apr 15, 2023
@thescientist13 thescientist13 changed the title re-serialize graph.json to provide page resources during serve optimizations re-serialize graph.json to include page resources when running serve command Apr 15, 2023
@thescientist13 thescientist13 marked this pull request as ready for review April 28, 2023 15:22
@thescientist13 thescientist13 changed the title re-serialize graph.json to include page resources when running serve command include resource tracking and serialization for all pages Apr 28, 2023
@thescientist13 thescientist13 added the P0 Critical issue that should get addressed ASAP label May 1, 2023
@thescientist13 thescientist13 force-pushed the bug/issue-1098-bundle-ssr-page-resources branch from c78dba3 to 6b359ed Compare May 6, 2023 13:05
@thescientist13 thescientist13 changed the title include resource tracking and serialization for all pages bug/include resource tracking and serialization for all pages May 6, 2023
@thescientist13 thescientist13 merged commit 06a9f3b into master May 6, 2023
@thescientist13 thescientist13 deleted the bug/issue-1098-bundle-ssr-page-resources branch May 6, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI P0 Critical issue that should get addressed ASAP SSR
Projects
None yet
1 participant