Show whitespace sequences in UI if they're significant #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
added
enhancement
status:needs work
In some parts of the UI where values may be used for searches or as part of banking rules, whitespace sequences (i.e. two spaces) may be significant and would cause a rule/search not to match when these values are copied and pasted without the sequence. HTML's default behaviour is to ignore whitespace sequences. This changes the whitespace handling to show things like two consecutive spaces so that values may be copied safely. The change is applied to the purpose/detail view on the transaction review page, and the purpose column of statement search.
pfigel
force-pushed
the
add-significant-whitespace
branch
from
db8d0dd
to
6bf6444
Compare
pfigel
commented
Aug 12, 2021
| @@ -209,7 +209,7 @@ protected function getCustomDataFieldSuggestions() { | |||
| '_BIC' => E::ts('Your BIC (<code>_BIC</code>)'), | |||
| '_party_IBAN' => E::ts('Other\'s IBAN (<code>_party_IBAN</code>)'), | |||
| '_party_BIC' => E::ts('Other\'s BIC (<code>_party_BIC</code>)'), | |||
| 'cancel_reason' => E::ts('Other\'s IBAN (<code>cancel_reason</code>)'), | |||
| 'cancel_reason' => E::ts('Cancel Reason (<code>cancel_reason</code>)'), | |||
There was a problem hiding this comment.
Unrelated, just spotted it and figured might as well fix it.
|
Resolved the conflict, should be good to review now. |
|
ping @bjendres |
|
Sorry, @pfigel, that fell through the (many) cracks. Thanks! |
bjendres
added
status:fixed
|
released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some parts of the UI where values may be used for searches or as part of banking rules, whitespace sequences (i.e. two spaces) may be significant and would cause a rule/search not to match when these values are copied and pasted without the sequence.
HTML's default behaviour is to ignore whitespace sequences. This changes the whitespace handling to show things like two consecutive spaces so that values may be copied safely.
The change is applied to the purpose/detail view on the transaction review page, and the purpose column of statement search.