Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented probability setting for bank account matching #310

Merged
merged 2 commits into from
Nov 30, 2020

Conversation

jaapjansma
Copy link
Collaborator

Current situation

When a transaction is matched by bank account this contact gets a probability of 100%. Meaning that in some matchers the transaction is matched with 100% certainity to this contact.
Sometimes this is not the desired situation.

For example in an organization where membership are stored on the household the individual might pay for the membership and as soon as the bank account is stored at the person level all other 'magic' disappears for identifying the household and the payment is recorded at the individual with 100% certainty and therefor the matcher is executed automatically.

Proposed solution

A setting where we can set the percentage for probability for bank account matching. In the above use case I am then able to lower the certainty so that automatic execution of those matches is prevented.

The setting is defaulted to 1.0 so when updating banking the current behavior is left as it is.

See below the screenshots of the setting screen and the matching screen

Screenshot_20201126_114848

Screenshot_20201126_114910

@bjendres
Copy link
Member

Looks great! Maybe add an upgrader step to set it to 1.0.

@jaapjansma
Copy link
Collaborator Author

I have added an upgrader to set it to 1.0.

@bjendres
Copy link
Member

@jaapjansma Cool, thanks. Should I merge then?

@jaapjansma
Copy link
Collaborator Author

Yes please do

@bjendres bjendres merged commit 9c66f67 into Project60:master Nov 30, 2020
@bjendres
Copy link
Member

Thanks @jaapjansma !

@bjendres bjendres added this to the CiviBanking 0.8 milestone Nov 30, 2020
@bjendres
Copy link
Member

released with 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants