Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/replace deprecated code #329

Open
2 of 11 tasks
jensschuppe opened this issue Mar 17, 2021 · 5 comments
Open
2 of 11 tasks

Remove/replace deprecated code #329

jensschuppe opened this issue Mar 17, 2021 · 5 comments
Labels
enhancement status:needs work There is code, but it needs additional work before it should be reviewed
Milestone
CiviBanking 1.0

Comments

@jensschuppe
Copy link
Collaborator

jensschuppe commented Mar 17, 2021 •
edited
Loading

  • Method CRM_Core_OptionGroup::getValue() is deprecated
  • Method CRM_Core_BAO_Setting::setItem() is deprecated
  • Method CRM_Core_Config::singleton()->defaultContactCountry()is deprecated
  • Class CRM_Core_EntityReference is deprecated
  • Method CRM_Case_XMLProcessor::mungeCaseType() is deprecated
  • Method CRM_Core_Error::fatal() is deprecated
  • Method CRM_Banking_Matcher_Context::getAccountContact() is deprecated
  • Method CRM_Contribute_PseudoConstant::financialType() is deprecated
  • Method CRM_Banking_BAO_BankAccountReference::format() is depreacted
  • Class property CRM_Core_DAO::$_nullObject is deprecated
  • Attributes passed to CRM_Core_Form::add() are not an array
@jensschuppe jensschuppe added this to the CiviBanking 0.8 milestone Mar 17, 2021
@jensschuppe jensschuppe reopened this Apr 1, 2021
jensschuppe added a commit that referenced this issue Apr 1, 2021
@jensschuppe
[#329] replace deprecated CRM_Core_OptionGroup::getValue() with civic…
b49fad6 
…rm_api3() calls
@jensschuppe jensschuppe added the status:needs work There is code, but it needs additional work before it should be reviewed label Apr 9, 2021
jensschuppe added a commit that referenced this issue May 10, 2021
@jensschuppe
[#329] Replace call to deprecated method CRM_Core_Config::singleton()…
5a5e501 
…->defaultContactCountry() with CRM_Core_BAO_Country::defaultContactCountry()
@bjendres bjendres mentioned this issue Jul 20, 2022
Closed
@bjendres
Copy link
Member

bjendres commented Sep 30, 2022 •
edited
Loading

released with 0.8.0

@eptbertram
Copy link

strftime is deprecated in PHP 8.1.0. It's used in importer plugins.
https://www.php.net/strftime

@eptbertram eptbertram mentioned this issue Nov 3, 2022
Closed
@bjendres
Copy link
Member

bjendres commented Nov 3, 2022

strftime is deprecated in PHP 8.1.0. It's used in importer plugins. https://www.php.net/strftime

Thanks, but....which ones? I can't find strftime in this repository. Or am I missing something?

@eptbertram
Copy link

oh boy, shame on me: there is plenty of strtotime here, but no strftime. Please excuse my mistake.

@bjendres
Copy link
Member

bjendres commented Nov 3, 2022

oh boy, shame on me: there is plenty of strtotime here, but no strftime

No worries. Better even, strtotime doesn't seem to become deprecated any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement status:needs work There is code, but it needs additional work before it should be reviewed
Projects
None yet
Milestone
CiviBanking 1.0
Development

No branches or pull requests
3 participants
@bjendres @jensschuppe @eptbertram