Add waypoints parameter to viaroute API #5345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
reviewed
Jan 23, 2019
features/testbot/via.feature
Outdated
|
|
||
| When I route I should get | ||
| | waypoints | route | | ||
| | a,b,c | abc,abc | |
There was a problem hiding this comment.
Let’s also test the case where the waypoint is located at an intersection and the route ends up making a non-obvious turn at that intersection; we’d expect the route to contain a maneuver at that point, rather than eliding it completely.
datendelphin
added a commit
to fossgis-routing-server/osrm-backend
that referenced
this pull request
Nov 19, 2020
- Changes from 5.21.0
- Build:
- ADDED: optionally build Node `lts` and `latest` bindings [Project-OSRM#5347](Project-OSRM#5347)
- Features:
- ADDED: new waypoints parameter to the `route` plugin, enabling silent waypoints [Project-OSRM#5345](Project-OSRM#5345)
- ADDED: data timestamp information in the response (saved in new file `.osrm.timestamp`). [Project-OSRM#5115](Project-OSRM#5115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This adds a
waypoints=parameter to theviarouteplugin, similar to the one on thematchplugin.What does it do? In a nutshell, it lets you suppress depart/arrive instructions for some waypoints. This is helpful if you want to provide some coordinates to guide the path the route takes, but don't want them to be announced as waypoints.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?