Fix "Error: write after end" and removed @bug tags #2936
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fix the problem that is caused by too early close of a log stream at process exit, but https://nodejs.org/api/child_process.html#child_process_event_exit
@daniel-j-h please could you check the change of
log.end
tolog.write
locally. I could reproduce it only with a release build and timeout 500ms./cc @springmeyer
Tasklist
Requirements / Relations
Supersedes #2934, if retest will be positive. Related to #2795