Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Error: write after end" and removed @bug tags #2936

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Conversation

oxidase
Copy link
Contributor

@oxidase oxidase commented Sep 20, 2016

Issue

Fix the problem that is caused by too early close of a log stream at process exit, but https://nodejs.org/api/child_process.html#child_process_event_exit

Note that when the 'exit' event is triggered, child process stdio streams might still be open.

@daniel-j-h please could you check the change of log.end to log.write locally. I could reproduce it only with a release build and timeout 500ms.
/cc @springmeyer

Tasklist

  • review
  • adjust for for comments

Requirements / Relations

Supersedes #2934, if retest will be positive. Related to #2795

https://nodejs.org/api/child_process.html#child_process_event_exit
Note that when the 'exit' event is triggered, child process stdio streams might still be open.
@springmeyer
Copy link
Contributor

I've been unable to reproduce with either Debug or Release build and with either OS X or Linux. Also tried export CUCUMBER_TIMEOUT=500 && npm test. So, I think the idea next step here is to have @daniel-j-h - who appears to be able to reproduce easily - test this branch and merge if it solves his issue.

@MoKob MoKob merged commit 3eac6ef into master Sep 21, 2016
@MoKob MoKob deleted the fix/write-after-end branch September 21, 2016 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants