Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add norm name arg to Swin UNETR BTCV #171

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Add norm name arg to Swin UNETR BTCV #171

merged 1 commit into from
Jan 4, 2023

Conversation

lweitkamp
Copy link
Contributor

The --norm_name argument is not present in the argparse. This will crash the main.py script in BTCV if --distributed is enabled.

if args.norm_name == "batch":
model = torch.nn.SyncBatchNorm.convert_sync_batchnorm(model)

This commit simply adds the --norm_name arg in the same location as is done in the BRATS 21 main.py file.

@tangy5
Copy link
Contributor

tangy5 commented Jan 4, 2023

Thank you. I feel this is true, there is no "norm_name" arg in the argparse. @wyli , can you take a look if this is good? If so, we can merge.

@tangy5 tangy5 self-requested a review January 4, 2023 00:34
@tangy5 tangy5 merged commit 07da7ad into Project-MONAI:main Jan 4, 2023
@Jamshidhsp
Copy link

@tangy5 Unfortunately, it doesn't solve the issue. Running main.py keeps on facing errors like:
Namespace object has no attribute 'data_dir'
I appreciate it if you can take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants