Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ai 183 #501

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Ai 183 #501

merged 1 commit into from
Dec 4, 2023

Conversation

neildsouth
Copy link
Contributor

Description

Fixes # .

Adding HL7 export

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@neildsouth neildsouth added the enhancement Enhancement to existing feature label Dec 1, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #501 (f9c3400) into develop (c9c16c2) will increase coverage by 1.89313%.
The diff coverage is 72.46622%.

❗ Current head f9c3400 differs from pull request most recent head 84c807b. Consider uploading reports for the commit 84c807b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #501         +/-   ##
===================================================
+ Coverage   74.20498%   76.09811%   +1.89312%     
===================================================
  Files            427         428          +1     
  Lines          28490       28253        -237     
  Branches        1219        1231         +12     
===================================================
+ Hits           21141       21500        +359     
+ Misses          6903        6308        -595     
+ Partials         446         445          -1     
Flag Coverage Δ
unittests 76.09811% <72.46622%> (+1.89312%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Client/InformaticsGatewayClient.cs 94.44444% <100.00000%> (+0.32679%) ⬆️
...Configuration/Hl7ApplicationConfigConfiguration.cs 100.00000% <100.00000%> (+100.00000%) ⬆️
...abase/EntityFramework/InformaticsGatewayContext.cs 100.00000% <100.00000%> (ø)
src/InformaticsGateway/Program.cs 81.51261% <100.00000%> (-0.88740%) ⬇️
...sGateway/Services/Common/OutputDataPluginEngine.cs 100.00000% <100.00000%> (ø)
...csGateway/Services/Export/DicomWebExportService.cs 86.48649% <100.00000%> (+5.16781%) ⬆️
...sGateway/Services/Export/ExtAppScuExportService.cs 76.71233% <100.00000%> (+1.03664%) ⬆️
...rmaticsGateway/Services/Export/ScuExportService.cs 85.71429% <100.00000%> (+16.96429%) ⬆️
...rmaticsGateway/Services/HealthLevel7/MllpClient.cs 78.30189% <100.00000%> (+0.94339%) ⬆️
...sGateway/Services/Http/HL7DestinationController.cs 0.00000% <ø> (ø)
... and 15 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c16c2...84c807b. Read the comment docs.

Signed-off-by: Neil South <neil.south@answerdigital.com>
@neildsouth neildsouth merged commit f46262e into develop Dec 4, 2023
27 of 28 checks passed
@neildsouth neildsouth deleted the AI-183 branch December 4, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants