-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more unit tests #455
Add more unit tests #455
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
1 similar comment
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
2 similar comments
/build |
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
1 similar comment
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the dints parts of the PR. All relevant changes are fine.
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
added unit tests are checked in this commit: In the latest commit, all temp changes (in order to trigger the unit tests) are reverted. |
/build |
1 similar comment
/build |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update, LGTM now.
Fixes # . ### Description This PR is used to add unit tests on the following bundles: - [x] spleen_deepedit_annotation - [x] pancreas_ct_dints_segmentation - [x] swin_unetr_btcv_segmentation - [x] pathology_tumor_detection ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). --------- Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Fixes # .
Description
This PR is used to add unit tests on the following bundles:
Status
Ready
Please ensure all the checkboxes:
./runtests.sh --codeformat
.version
andchangelog
inmetadata.json
if changing an existing bundle.CONTRIBUTING.md
).monai
,pytorch
andnumpy
are correct inmetadata.json
.eval_metrics
of the provided weights and TorchScript modules.large_file.yml
./home/your_name/
for"bundle_root"
).