Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fixed wrong space directions interpretation in nrrd reader #8091

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

che85
Copy link
Contributor

@che85 che85 commented Sep 17, 2024

the vectors presented for space directions are column vectors

ref: https://teem.sourceforge.net/nrrd/format.html#spacedirections

Description

A few sentences describing the changes proposed in this pull request.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

the vectors presented for space directions are column vectors

ref: https://teem.sourceforge.net/nrrd/format.html#spacedirections
Signed-off-by: Christian Herz <christianherz1985@gmail.com>
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KumoLiu
Copy link
Contributor

KumoLiu commented Sep 18, 2024

/build

@KumoLiu KumoLiu enabled auto-merge (squash) September 18, 2024 06:25
@KumoLiu KumoLiu merged commit 5bff478 into Project-MONAI:dev Sep 18, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants