Add Average Precision to metrics #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
for more information, see https://pre-commit.ci
|
/build |
|
hi @KumoLiu, could you please have a look at this PR? |
KumoLiu
reviewed
Oct 22, 2024
ericspod
reviewed
Oct 22, 2024
ericspod
approved these changes
Oct 22, 2024
|
Hi @thibaultdvx we've updated our tests with a directory structure, if you could please look over comments and update where your test files are we can come back to this PR. Thanks! |
Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Signed-off-by: Thibault de Varax <154365476+thibaultdvx@users.noreply.github.com>
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
thibaultdvx
force-pushed
the
8085-average-precision
branch
from
a10d5c6 to
4fc9cf5
Compare
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
|
Hi @thibaultdvx I'm going to merge recent changes into your branch and see if that sorts the test issues, I don't think it was related to PR either. |
ericspod
reviewed
Feb 18, 2025
|
I think this is good to go now, @KumoLiu if you could please trigger blossom, thanks. |
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
|
/build |
|
Hi @thibaultdvx, please help fix the format issue: https://github.com/Project-MONAI/MONAI/actions/runs/13406057032/job/37446075381?pr=8089 |
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org>
|
/build |
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
Mar 10, 2025
Fixes Project-MONAI#8085. ### Description Average Precision is very similar to ROCAUC, so I was very much inspired by the ROCAUC implementation. More precisely, I created: - `AveragePrecisionMetric` and `compute_average_precision` in `monai.metrics`, - a handler called `AveragePrecision` in `monai.handlers`, - three unittest modules: `test_compute_average_precision.py`, `test_handler_average_precision.py` and `test_handler_average_precision_dist.py`. I also modified the docs to mention Average Precision. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [x] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [x] In-line docstrings updated. - [x] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: thibaultdvx <thibault.devarax@icm-institute.org> Signed-off-by: Thibault de Varax <154365476+thibaultdvx@users.noreply.github.com> Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: YunLiu <55491388+KumoLiu@users.noreply.github.com> Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8085.
Description
Average Precision is very similar to ROCAUC, so I was very much inspired by the ROCAUC implementation.
More precisely, I created:
AveragePrecisionMetricandcompute_average_precisioninmonai.metrics,AveragePrecisioninmonai.handlers,test_compute_average_precision.py,test_handler_average_precision.pyandtest_handler_average_precision_dist.py.I also modified the docs to mention Average Precision.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.