-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix experiment already exist issue in MLFlowHandler
#7916
Conversation
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
I think one more thing to discuss is whether MONAI should handle the multiprocessing scene of the mlflow handler or users should implement it in their code. If we'd like to do this, we'd better to use a more formal way like a lock for this. Thanks |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
A good point. I didn't find a multiprocessing scene, the issue here is that in the nvflare real world tests, it will raise an error during creating experiments in different sites. Perhaps we can add try-catch block here and if there is a real-world case, we can refactor the logic. What do you think? Thanks. |
Sure, we can leave this one as it is. But I think from the flare side, they need to handle this multiprocessing issue. |
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
/build |
4 similar comments
/build |
/build |
/build |
/build |
/build |
1 similar comment
/build |
/build |
Try to fixes NVIDIA/NVFlare#2698.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.