-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
40-validation-early-stop #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @madil90 ,
Thanks for your quick PR, I just added 2 comments inline, could you please help take a look?
Thanks.
@madil90 could you update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me for current MVP version.
We may need to refactor utils part in later sprints.
And define unified format for model output, then we can use the util function "stopping_fn_from_loss".
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me for current MVP version.
We may need to refactor utils part in later sprints.
And define unified format for model output, then we can use the util function "stopping_fn_from_loss".
Thanks.
db5d9b2
to
4175142
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
Fixes #40 fixes #8
Description
Added example for model validation every step with metric logging. Added util functions for early stopping.
Status
Ready
Types of changes
with this PR, running the training program gives: