Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add class label option to write metric report to improve readability … #7249

Merged

Conversation

elitap
Copy link
Contributor

@elitap elitap commented Nov 21, 2023

add class label option to write metric report to improve readability, without that option in case of many classes the resulting report is very hard to interpret.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

elitap and others added 2 commits November 21, 2023 09:46
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please address the mypy error?

@KumoLiu KumoLiu requested review from ericspod and Nic-Ma November 21, 2023 10:25
Signed-off-by: elitap <elias.tappeiner@gmx.at>
Signed-off-by: elitap <elias.tappeiner@gmx.at>
Signed-off-by: elitap <elias.tappeiner@gmx.at>
monai/handlers/utils.py Outdated Show resolved Hide resolved
elitap and others added 5 commits November 21, 2023 13:02
Signed-off-by: elitap <elias.tappeiner@gmx.at>
Signed-off-by: elitap <elias.tappeiner@gmx.at>
…://github.com/elitap/MONAI into add_class_label_option_to_write_metric_report

Signed-off-by: elitap <elias.tappeiner@gmx.at>
Signed-off-by: elitap <elias.tappeiner@gmx.at>
@KumoLiu
Copy link
Contributor

KumoLiu commented Nov 22, 2023

/build

1 similar comment
@KumoLiu
Copy link
Contributor

KumoLiu commented Nov 22, 2023

/build

@KumoLiu KumoLiu merged commit 8e134b8 into Project-MONAI:dev Nov 22, 2023
28 checks passed
marksgraham pushed a commit to marksgraham/MONAI that referenced this pull request Jan 30, 2024
Project-MONAI#7249)

add class label option to write metric report to improve readability,
without that option in case of many classes the resulting report is very
hard to interpret.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

---------

Signed-off-by: elitap <elias.tappeiner@gmx.at>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Mark Graham <markgraham539@gmail.com>
juampatronics pushed a commit to juampatronics/MONAI that referenced this pull request Mar 25, 2024
Project-MONAI#7249)

add class label option to write metric report to improve readability,
without that option in case of many classes the resulting report is very
hard to interpret.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

---------

Signed-off-by: elitap <elias.tappeiner@gmx.at>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610 pushed a commit to Yu0610/MONAI that referenced this pull request Apr 11, 2024
Project-MONAI#7249)

add class label option to write metric report to improve readability,
without that option in case of many classes the resulting report is very
hard to interpret.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).

---------

Signed-off-by: elitap <elias.tappeiner@gmx.at>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants