Fixup mypy 1.7.0 errors #7231
Merged
Fixup mypy 1.7.0 errors #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KumoLiu
approved these changes
Nov 14, 2023
Shadow-Devil
force-pushed
the
feature/fix_mypy_1_7_0
branch
from
48ea302
to
4b7d97b
Compare
Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
Signed-off-by: Felix Schnabel <f.schnabel@tum.de>
Shadow-Devil
force-pushed
the
feature/fix_mypy_1_7_0
branch
from
d8556f3
to
63909a5
Compare
|
Hi @ericspod, do you have any other comments on this PR otherwise I think we could merge this one first to avoid ci broken in other PRs. Thanks! |
|
/build |
marksgraham
pushed a commit
to marksgraham/MONAI
that referenced
this pull request
Jan 30, 2024
Fixes Project-MONAI#7230. ### Description Fix the typing issues and the deprecation. Also always run type checking with Linux environment, since ForkServerContext is not available on Windows. ### Types of changes - [x] Non-breaking change (fix or new feature that would not break existing functionality). --------- Signed-off-by: Felix Schnabel <f.schnabel@tum.de> Signed-off-by: Mark Graham <markgraham539@gmail.com>
juampatronics
pushed a commit
to juampatronics/MONAI
that referenced
this pull request
Mar 25, 2024
Fixes Project-MONAI#7230. ### Description Fix the typing issues and the deprecation. Also always run type checking with Linux environment, since ForkServerContext is not available on Windows. ### Types of changes - [x] Non-breaking change (fix or new feature that would not break existing functionality). --------- Signed-off-by: Felix Schnabel <f.schnabel@tum.de> Signed-off-by: Juan Pablo de la Cruz Gutiérrez <juampatronics@gmail.com>
Yu0610
pushed a commit
to Yu0610/MONAI
that referenced
this pull request
Apr 11, 2024
Fixes Project-MONAI#7230. ### Description Fix the typing issues and the deprecation. Also always run type checking with Linux environment, since ForkServerContext is not available on Windows. ### Types of changes - [x] Non-breaking change (fix or new feature that would not break existing functionality). --------- Signed-off-by: Felix Schnabel <f.schnabel@tum.de> Signed-off-by: Yu0610 <612410030@alum.ccu.edu.tw>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7230.
Description
Fix the typing issues and the deprecation.
Also always run type checking with Linux environment, since ForkServerContext is not available on Windows.
Types of changes