Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify list_data_collate and collate_meta_tensor #7165

Merged
merged 9 commits into from
Oct 26, 2023
Merged

simplify list_data_collate and collate_meta_tensor #7165

merged 9 commits into from
Oct 26, 2023

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Oct 26, 2023

Fixes #5917

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@KumoLiu
fix Project-MONAI#5917
13a914c 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
backwards compatibility
bbc1f78 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
fix ci
70c058d 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu marked this pull request as ready for review October 26, 2023 10:05
@KumoLiu KumoLiu requested review from wyli, ericspod and Nic-Ma October 26, 2023 10:05
wyli
wyli approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a minor refactoring to use the latest pytorch API, please let me know any concerns @ericspod @Nic-Ma.

@wyli
Copy link
Contributor

wyli commented Oct 26, 2023

/build

ericspod
ericspod reviewed Oct 26, 2023
View reviewed changes
monai/data/utils.py Outdated Show resolved Hide resolved
@KumoLiu @ericspod
Update monai/data/utils.py
ab3009b 
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
minor fix
02188d6 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
Merge branch 'collate' of https://github.com/KumoLiu/MONAI into collate
1f9970e
@KumoLiu
fix flake8
357769d 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
address comments
e7f0086 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu
minor fix
46ef518 
Signed-off-by: KumoLiu <yunl@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Oct 26, 2023

/build

@wyli wyli enabled auto-merge (squash) October 26, 2023 16:24
@wyli wyli merged commit fa15eec into Project-MONAI:dev Oct 26, 2023
23 checks passed
@KumoLiu KumoLiu deleted the collate branch October 27, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod left review comments

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simplify list_data_collate and collate_meta_tensor using collate
3 participants
@KumoLiu @wyli @ericspod