Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6602 Update bundle properties #6607

Merged
merged 4 commits into from
Jun 13, 2023
Merged

6602 Update bundle properties #6607

merged 4 commits into from
Jun 13, 2023

Conversation

yiheng-wang-nv
Copy link
Contributor

Fixes #6602 .

Description

This PR is used to change the required properties of bundle workflow. It also modifies the _check_optional_id function to ensure ref is existing.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

yiheng-wang-nv and others added 2 commits June 13, 2023 12:20
@Nic-Ma Nic-Ma requested a review from SachidanandAlle June 13, 2023 04:49
@yiheng-wang-nv
update docstring
de09398 
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv
Merge branch '6602-modify-bundle-properties' of github.com:yiheng-wan…
3e9c07f 
…g-nv/MONAI into 6602-modify-bundle-properties
SachidanandAlle
SachidanandAlle approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@SachidanandAlle SachidanandAlle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required check will not have any impact on MONAILabel.

@wyli
Copy link
Contributor

wyli commented Jun 13, 2023

/build

@wyli wyli enabled auto-merge (squash) June 13, 2023 08:45
@wyli wyli merged commit a1c4371 into Project-MONAI:dev Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SachidanandAlle SachidanandAlle SachidanandAlle approved these changes

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify TrainProperties in monai.bundle.properties
3 participants
@yiheng-wang-nv @wyli @SachidanandAlle