Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6426 warn when inverting lazy + non-lazy-invertible transforms #6428

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Apr 25, 2023

Fixes #6426

Description

only warn when checking the most recent applied operations

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from ericspod, Nic-Ma and KumoLiu April 25, 2023 09:12
@atbenmurray atbenmurray self-requested a review April 25, 2023 11:58
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @atbenmurray would like to review.

Copy link
Contributor

@atbenmurray atbenmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6257 Fixes the issue that required this special case code. I don't think that in the general case it should be possible to end up with pending transforms if you have used compose. Is this change (and the underlying warning) actually still necessary?

@atbenmurray atbenmurray requested a review from ericspod April 25, 2023 12:01
@wyli
Copy link
Contributor Author

wyli commented Apr 25, 2023

yes, it's necessary to warn the user defined transforms

@wyli
Copy link
Contributor Author

wyli commented Apr 25, 2023

/build

@wyli wyli merged commit 7ea082e into Project-MONAI:dev Apr 25, 2023
@wyli wyli deleted the 6426-invertd branch April 27, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

too many warning messages inverse.py
4 participants