Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ruff precommit autofixes #6402

Merged
merged 9 commits into from
Apr 20, 2023
Merged

Adds ruff precommit autofixes #6402

merged 9 commits into from
Apr 20, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Apr 19, 2023

Description

https://github.com/charliermarsh/ruff

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 5 commits April 19, 2023 19:24
@wyli
temp test
755b960 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes
06c5b6e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
update
b88f183 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
remove temp
04e60d1 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes
b08efb5 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review April 19, 2023 19:31
@pxLi
Copy link
Contributor

pxLi commented Apr 20, 2023

/build

1 similar comment
@pxLi
Copy link
Contributor

pxLi commented Apr 20, 2023

/build

@wyli
Copy link
Contributor Author

wyli commented Apr 20, 2023

/build

@wyli wyli requested a review from mingxin-zheng April 20, 2023 08:12
@wyli
Copy link
Contributor Author

wyli commented Apr 20, 2023

/build

@wyli wyli enabled auto-merge (squash) April 20, 2023 10:33
@wyli wyli disabled auto-merge April 20, 2023 10:46
@pre-commit-ci @wyli
[pre-commit.ci] auto fixes from pre-commit.com hooks
3aaa10e 
remove pylint from requirements-dev --GNU license

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Apr 20, 2023

/build

@wyli wyli enabled auto-merge (squash) April 20, 2023 12:56
@wyli wyli merged commit 79723ca into Project-MONAI:dev Apr 20, 2023
@wyli wyli deleted the adds-ruff branch April 20, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingxin-zheng mingxin-zheng mingxin-zheng approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyli @pxLi @mingxin-zheng