Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix casting of location dtype in GridPatch #4635

Merged
merged 8 commits into from
Jul 6, 2022
Merged

Fix casting of location dtype in GridPatch #4635

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
066af82
Move dictionary inserts to its definition (#4594)
deepsource-autofix[bot] Jun 27, 2022
53864ca
disjoining location dtype from array dtype
vale-salvatelli Jul 5, 2022
7f76093
addinig coomment
vale-salvatelli Jul 5, 2022
62f02ed
Merge branch 'Project-MONAI:dev' into patch-2
vale-salvatelli Jul 5, 2022
4a69951
fixing typo in if
vale-salvatelli Jul 5, 2022
2e552df
simplifying - thanks wyli for the feedback
vale-salvatelli Jul 6, 2022
e27b035
[MONAI] code formatting
monai-bot Jul 6, 2022
5916329
Merge branch 'dev' into patch-2
wyli Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion monai/transforms/spatial/array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3128,8 +3128,16 @@ def __call__(self, array: NdarrayOrTensor):
patched_image, locations = self.filter_threshold(patched_image, locations)

# Convert to original data type
# Locations data type should differ from array data type
if isinstance(array, torch.Tensor):
location_dtype = torch.int
elif isinstance(array, np.ndarray):
location_dtype = np.int
else:
location_dtype = None
output = list(
zip(convert_to_dst_type(src=patched_image, dst=array)[0], convert_to_dst_type(src=locations, dst=array)[0])
zip(convert_to_dst_type(src=patched_image, dst=array)[0],
convert_to_dst_type(src=locations, dst=array, dtype=location_dtype)[0])
vale-salvatelli marked this conversation as resolved.
Show resolved Hide resolved
)

# Pad the patch list to have the requested number of patches
Expand Down