Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4589 enable dropout in dynunet #4590

Merged
merged 3 commits into from
Jun 27, 2022
Merged

4589 enable dropout in dynunet #4590

merged 3 commits into from
Jun 27, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jun 26, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #4589

Description

when conv_only=True, the dropout parameter is ignored in get_conv_layer, this causes some misconfiguration of the networks.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested a review from yiheng-wang-nv June 26, 2022 13:23
@wyli wyli changed the title 4589 enable dropout 4589 enable dropout in dynunet Jun 26, 2022
@wyli
Copy link
Contributor Author

wyli commented Jun 26, 2022

/integration-test

@wyli wyli marked this pull request as ready for review June 26, 2022 15:03
@Nic-Ma Nic-Ma requested review from ericspod and rijobro June 27, 2022 02:40
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyli . LGTM This PR fixes unworked dropout arg in: #2947 FYI @diazandr3s

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jun 27, 2022

/build

@wyli wyli enabled auto-merge (squash) June 27, 2022 06:39
@wyli wyli merged commit d4c6521 into Project-MONAI:dev Jun 27, 2022
@wyli wyli deleted the fixes-dropout branch June 27, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropout is not firing in DynUNet class
2 participants