Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap Type to the typing of writer parameter of SaveImage #4561

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Wrap Type to the typing of writer parameter of SaveImage #4561

merged 2 commits into from
Jun 23, 2022

Conversation

function2-llx
Copy link
Contributor

@function2-llx function2-llx commented Jun 22, 2022 •
edited
Loading

Fixes #4560.

Status

ready for review

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wrap Type to the typing of writer parameter of SaveImage
b712983 
Signed-off-by: function2 <luolx21@mails.tsinghua.edu.cn>
@function2-llx function2-llx force-pushed the 4560-fix-save_image-typing branch from 0f850f7 to b712983 Compare June 22, 2022 09:30
wyli
wyli approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, it looks good to me.

I'll merge this one if you mark it 'ready for review'.

@function2-llx function2-llx marked this pull request as ready for review June 22, 2022 18:34
@function2-llx function2-llx changed the title [WIP] wrap Type to the typing of writer parameter of SaveImage wrap Type to the typing of writer parameter of SaveImage Jun 22, 2022
@function2-llx function2-llx changed the title wrap Type to the typing of writer parameter of SaveImage Wrap Type to the typing of writer parameter of SaveImage Jun 22, 2022
@wyli wyli mentioned this pull request Jun 23, 2022
Closed
@wyli
closes Project-MONAI#4568
9b64618 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Jun 23, 2022

/build

@wyli wyli enabled auto-merge (squash) June 23, 2022 10:10
@wyli wyli merged commit d6b4593 into Project-MONAI:dev Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong typing for writer parameter of SaveImage
2 participants
@function2-llx @wyli