Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4477 4478 iterables enhancements #4479

Merged
merged 7 commits into from
Jun 10, 2022
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jun 10, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #4477
Fixes #4478

Description

  • skip ShuffleBuffer.set_random_state method (the seed controls the state)
  • GridPatchDataset's self.transform is left empty, because it's shared with the base class.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli and others added 2 commits June 10, 2022 12:08
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 2 commits June 10, 2022 12:16
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jun 10, 2022

/build

@wyli wyli enabled auto-merge (squash) June 10, 2022 12:40
@wyli wyli merged commit e3b47fe into Project-MONAI:dev Jun 10, 2022
@wyli wyli deleted the fixes-iterable-datasets branch June 11, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants