Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RotateBox90 transforms #4460

Merged
merged 10 commits into from
Jun 7, 2022
Merged

Add RotateBox90 transforms #4460

merged 10 commits into from
Jun 7, 2022

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented Jun 6, 2022

Fixes #3572 .

Description

Add RotateBox90 transforms

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao added 2 commits June 6, 2022 01:12
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
pre-commit-ci bot and others added 5 commits June 6, 2022 05:18
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao marked this pull request as ready for review June 6, 2022 07:11
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli and removed request for Nic-Ma June 6, 2022 07:11
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me, @Nic-Ma please help review if you have time...

@wyli
Copy link
Contributor

wyli commented Jun 7, 2022

/build

@wyli wyli enabled auto-merge (squash) June 7, 2022 05:55
@wyli wyli merged commit f3cbba2 into Project-MONAI:dev Jun 7, 2022
@Can-Zhao Can-Zhao deleted the rot90 branch June 8, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box transforms
2 participants