Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RetinaNet detector loss computation #4446

Merged
merged 12 commits into from
Jun 3, 2022
Merged

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented Jun 2, 2022

Signed-off-by: Can Zhao canz@nvidia.com

Fixes #4384 .

Description

add loss computation to retinanet detector

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone Jun 2, 2022
Can-Zhao and others added 9 commits June 2, 2022 19:42
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao marked this pull request as ready for review June 3, 2022 02:05
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli June 3, 2022 02:05
@Can-Zhao Can-Zhao requested a review from mibaumgartner June 3, 2022 04:29
@Can-Zhao Can-Zhao changed the title add loss computation to detector add RetinaNet detector loss computation Jun 3, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented Jun 3, 2022

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loss computation, and initial integration results look reasonable according to Can.

@wyli wyli merged commit 4cddaa8 into Project-MONAI:dev Jun 3, 2022
@wyli wyli deleted the detector branch June 3, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loss computation for RetinaNet
2 participants