Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Probability Map Producer Handler #4382

Merged
merged 22 commits into from
Jun 1, 2022
Merged

Refactor Probability Map Producer Handler #4382

merged 22 commits into from
Jun 1, 2022

Conversation

bhashemian
Copy link
Member

@bhashemian bhashemian commented May 29, 2022 •
edited
Loading

Fixes #4381

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

bhashemian added 5 commits May 29, 2022 03:59
@bhashemian
Update wsi metadata names
d14ceda 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian
Implement prob map handler
a6af651 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian
Update test cases
f1ce270 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian
Deprecate the prob map producer in monai.app.pathology
66935b1 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian
Update to probability_maps.py and add docs
dd49756 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian marked this pull request as ready for review May 29, 2022 15:00
@bhashemian
simplify image initialization
6785a9f 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
pre-commit-ci bot and others added 3 commits May 29, 2022 15:33
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
54021ee 
for more information, see https://pre-commit.ci
@bhashemian
Fix sort
8aafa5d 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian
Merge branch 'dev' into update-prob-map
b353959
@bhashemian bhashemian requested review from Nic-Ma and wyli May 30, 2022 16:04
bhashemian added 5 commits May 30, 2022 18:47
@bhashemian
Update wsireader tests
bf9e191 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian
Merge branch 'dev' into update-prob-map
39d829f
@bhashemian
Merge branch 'dev' into update-prob-map
6472746
@bhashemian
Fix imports
78acc6b 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian
Merge branch 'dev' into update-prob-map
af41752
@bhashemian bhashemian marked this pull request as draft May 30, 2022 22:13
bhashemian added 2 commits May 30, 2022 18:13
@bhashemian
Merge branch 'dev' into update-prob-map
85d3a16
@bhashemian
Create enum for prob map keys
12b48b4 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian marked this pull request as ready for review May 31, 2022 13:54
@bhashemian bhashemian enabled auto-merge (squash) May 31, 2022 13:55
@bhashemian
Copy link
Member Author

@Nic-Ma, any other comments here? Otherwise, it should be ready to merge. Thanks

@bhashemian bhashemian mentioned this pull request Jun 1, 2022
Merged
7 tasks
Nic-Ma
Nic-Ma approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Looks good to me except for minor comments inline.

Thanks.

monai/data/wsi_datasets.py Show resolved Hide resolved
@bhashemian
update doctrting
f31d09a 
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jun 1, 2022

/black

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jun 1, 2022

/build

@bhashemian bhashemian merged commit 40373b2 into Project-MONAI:dev Jun 1, 2022
@bhashemian bhashemian deleted the update-prob-map branch June 1, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@wyli wyli Awaiting requested review from wyli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor ProbMapProducer
2 participants
@bhashemian @Nic-Ma