Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RetinaNet network #4378

Merged
merged 25 commits into from
May 30, 2022
Merged

add RetinaNet network #4378

merged 25 commits into from
May 30, 2022

Conversation

Can-Zhao
Copy link
Collaborator

@Can-Zhao Can-Zhao commented May 28, 2022 •
edited
Loading

Signed-off-by: Can Zhao canz@nvidia.com

Fixes #4383.
add retinanet

Description

add retinanet networks

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao and others added 2 commits May 28, 2022 14:44
@Can-Zhao
add retinanet
821ffcd 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
Merge branch 'dev' into detection_retinanet
0c7595a
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 28, 2022
@Can-Zhao Can-Zhao changed the title add retinanet add RetinaNet network May 28, 2022
Can-Zhao added 4 commits May 28, 2022 15:33
@Can-Zhao
try to fix import
85b744c 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
Merge branch 'detection_retinanet' of github.com:Can-Zhao/MONAI into …
7d5107f 
…detection_retinanet
@Can-Zhao
try to fix import
4941c37 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
try to fix import
cd9497f 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
Copy link
Collaborator Author

/black

Can-Zhao added 4 commits May 28, 2022 16:01
@Can-Zhao
reformat
47c2858 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
clean unused par
5be201d 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
clean unused par
e819e76 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
clean unused par
394fbbe 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao marked this pull request as ready for review May 28, 2022 21:48
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 29, 2022 03:28
@wyli
fixes unit test
5c3ecc3 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the detection_retinanet branch from 664ef0b to 5c3ecc3 Compare May 29, 2022 12:21
Can-Zhao added 4 commits May 29, 2022 10:52
@Can-Zhao
remove base detection network abstract class
254614c 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
tested with detection pipeline
6ff3c8f 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
reformat
781fc74 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
fic doc
887c80a 
Signed-off-by: Can Zhao <canz@nvidia.com>
wyli
wyli approved these changes May 29, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New net arch with 2/3d support, torchscript support not tested.

@wyli
Copy link
Contributor

wyli commented May 29, 2022

/build

@wyli wyli enabled auto-merge (squash) May 29, 2022 18:20
@Nic-Ma Nic-Ma disabled auto-merge May 30, 2022 06:18
Nic-Ma
Nic-Ma approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overall looks good to me.
Put some minor comments inline.
I will disable the auto-merge for a while.

Thanks.

tests/test_retinanet.py Show resolved Hide resolved
monai/apps/detection/networks/retinanet_network.py Show resolved Hide resolved
monai/apps/detection/networks/retinanet_network.py Outdated Show resolved Hide resolved
Can-Zhao added 4 commits May 30, 2022 05:24
@Can-Zhao
add unit test for torchscript, both for fpn and retinanet
4c35d0d 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
docstring
8395cca 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
add skipversion in test
1af7240 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
fix torchvision import
ebb4216 
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
Copy link
Collaborator Author

New net arch with 2/3d support, torchscript support not tested.

torchscript support has been tested now

@Can-Zhao
fix torchvision import
4c3f708 
Signed-off-by: Can Zhao <canz@nvidia.com>
Nic-Ma
Nic-Ma reviewed May 30, 2022
View reviewed changes
tests/test_retinanet.py Outdated Show resolved Hide resolved
Can-Zhao and others added 2 commits May 30, 2022 06:16
@Can-Zhao
fix comment
8dcfa8e 
Signed-off-by: Can Zhao <canz@nvidia.com>
@wyli
Merge branch 'dev' into detection_retinanet
32782f3
@wyli
Copy link
Contributor

wyli commented May 30, 2022

/build

@wyli wyli enabled auto-merge (squash) May 30, 2022 15:22
@wyli wyli merged commit 9133e35 into Project-MONAI:dev May 30, 2022
@Can-Zhao Can-Zhao deleted the detection_retinanet branch May 30, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
Feature request
Projects
None yet
Milestone
Detection module [P0]
Development

Successfully merging this pull request may close these issues.

Add RetinaNet network
3 participants
@Can-Zhao @wyli @Nic-Ma