Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4343 adds interp mode #4344

Merged
merged 3 commits into from
May 26, 2022
Merged

4343 adds interp mode #4344

merged 3 commits into from
May 26, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented May 25, 2022 •
edited
Loading

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #4343

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
adds interp mode
ec83c5b 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title adds interp mode 4343 adds interp mode May 25, 2022
@wyli
update docstrings
30152f4 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented May 25, 2022

/build

@wyli wyli force-pushed the 4343-interpolate-mode branch from 2ad2251 to 797de42 Compare May 25, 2022 17:41
@wyli
Copy link
Contributor Author

wyli commented May 25, 2022

/build

@wyli wyli marked this pull request as ready for review May 25, 2022 19:30
Nic-Ma
Nic-Ma approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement.
Looks good to me.

Thanks.

@wyli wyli merged commit 15eda2a into Project-MONAI:dev May 26, 2022
@wyli wyli deleted the 4343-interpolate-mode branch May 26, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InterpolateMode add support for 'nearest-exact' mode
2 participants
@wyli @Nic-Ma