Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update swin_unetr block parameter names #4311

Merged
merged 7 commits into from
May 22, 2022
Merged

update swin_unetr block parameter names #4311

merged 7 commits into from
May 22, 2022

Conversation

ahatamiz
Copy link
Contributor

@ahatamiz ahatamiz commented May 21, 2022 •
edited
Loading

Signed-off-by: ahatamizadeh ahatamizadeh@nvidia.com

Description

This PR changes the following:

  • block names to be compatible with pre-trained weights
  • decreases the number of feature size to 24 as the base model to be more memory efficient.
  • sets Normalize to be default option.

Status

*Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@ahatamiz
update swin_unetr block name
3952dc2 
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz requested a review from wyli May 21, 2022 21:46
ahatamiz added 2 commits May 21, 2022 14:55
@ahatamiz
update swin_unetr block name
c2e57a0 
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz
update swin_unetr block name
b92cdb2 
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz changed the title update swin_unetr block name update swin_unetr block name and UnetResBlock May 22, 2022
@ahatamiz ahatamiz changed the title update swin_unetr block name and UnetResBlock update swin_unetr block and UnetResBlock May 22, 2022
ahatamiz added 2 commits May 21, 2022 23:02
@ahatamiz
update swin_unetr block name
96c7bbd 
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz
update swin_unetr block name
cf6debe 
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz changed the title update swin_unetr block and UnetResBlock update swin_unetr block May 22, 2022
@ahatamiz ahatamiz changed the title update swin_unetr block update swin_unetr block parameter names May 22, 2022
@ahatamiz
update swin_unetr block name
02fae63 
Signed-off-by: ahatamizadeh <ahatamizadeh@nvidia.com>
@ahatamiz ahatamiz requested a review from Nic-Ma May 22, 2022 08:23
@Nic-Ma Nic-Ma requested review from ericspod and yiheng-wang-nv May 22, 2022 08:28
@wyli
Copy link
Contributor

wyli commented May 22, 2022

/build

@wyli wyli enabled auto-merge (squash) May 22, 2022 10:40
@wyli wyli merged commit 655c8e7 into Project-MONAI:dev May 22, 2022
@ahatamiz ahatamiz deleted the swin_unetr_v2 branch May 22, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahatamiz @wyli