Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add box transforms for affine and zoom #4309

Merged
merged 23 commits into from
May 24, 2022
Merged

Conversation

Can-Zhao
Copy link
Collaborator

Signed-off-by: Can Zhao canz@nvidia.com

Fixes #3572 .

Description

add box transforms for affine and zoom
tested with detection training pipeline

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Can Zhao <canz@nvidia.com>
Can-Zhao and others added 2 commits May 22, 2022 15:59
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao marked this pull request as ready for review May 22, 2022 21:41
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 22, 2022 21:46
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please help also add the unit tests for these new transforms?

Thanks.

monai/apps/detection/transforms/array.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/array.py Outdated Show resolved Hide resolved
monai/apps/detection/transforms/array.py Show resolved Hide resolved
Can-Zhao and others added 6 commits May 23, 2022 10:12
@Can-Zhao
Copy link
Collaborator Author

Could you please help also add the unit tests for these new transforms?

Thanks.

I will do it today. Thanks

Can-Zhao and others added 4 commits May 23, 2022 15:14
Can-Zhao and others added 9 commits May 23, 2022 18:15
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao
Copy link
Collaborator Author

Could you please help also add the unit tests for these new transforms?

Thanks.

Added! Thanks

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this provides essential transforms for bounding box based detection pipelines

@wyli
Copy link
Contributor

wyli commented May 24, 2022

/build

@wyli wyli enabled auto-merge (squash) May 24, 2022 07:28
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor

wyli commented May 24, 2022

/build

@wyli wyli merged commit a1dc54a into Project-MONAI:dev May 24, 2022
@Can-Zhao Can-Zhao deleted the box_transform branch May 24, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box transforms
3 participants