Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3595 - adds a folder layout class #3655

Merged
merged 6 commits into from
Jan 18, 2022
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 13, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #3595

Description

this is used as part of SaveImage transform,
to help maintain a list of output files (from a training minibatch's metadata)

subject = meta_data[Key.FILENAME_OR_OBJ] if meta_data else str(self._data_index)
patch_index = meta_data.get(Key.PATCH_INDEX, None) if meta_data else None
filename = self.folder_layout.filename(subject=f"{subject}", idx=patch_index)

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the adds-folder-layout branch from e3b7b2d to c2eaebe Compare January 17, 2022 12:55
@wyli wyli changed the title 3589 - adds a folder layout class 3595 - adds a folder layout class Jan 17, 2022
@wyli
Copy link
Contributor Author

wyli commented Jan 18, 2022

/build

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for some minor inline comments.
@ericspod @rijobro Do you have any other comments?

Thanks.

monai/data/folder_layout.py Outdated Show resolved Hide resolved
monai/data/folder_layout.py Outdated Show resolved Hide resolved
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jan 18, 2022

/build

@wyli wyli enabled auto-merge (squash) January 18, 2022 19:20
@wyli wyli merged commit c2b6459 into Project-MONAI:dev Jan 18, 2022
@wyli wyli deleted the adds-folder-layout branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants