Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3194 update vitautoenc for 2d #3420

Merged
merged 3 commits into from
Dec 1, 2021
Merged

3194 update vitautoenc for 2d #3420

merged 3 commits into from
Dec 1, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 30, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

follow up of #3194

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title update vitautoenc for 2d 3194 update vitautoenc for 2d Nov 30, 2021
Copy link
Collaborator

@finalelement finalelement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement.
Looks good to me, @finalelement could you please help also review and double confirm it?

Thanks.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Dec 1, 2021

/build

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Dec 1, 2021

Hi @wyli ,

There is some error in the CI tests:

ValueError: Sequence must have length 3, got 2.

Thanks.

…eights

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Dec 1, 2021

/build

@wyli
Copy link
Contributor Author

wyli commented Dec 1, 2021

/build

@wyli wyli enabled auto-merge (squash) December 1, 2021 12:18
@wyli wyli merged commit f94e768 into Project-MONAI:dev Dec 1, 2021
@wyli wyli deleted the vitautoenc-2d branch January 9, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants