Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2721 - enhance transform figures #3083

Merged
merged 2 commits into from
Oct 8, 2021
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Oct 8, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #2721

Description

  • adds a rough estimation for the height ratios when comparing before/after
  • adds a few labels for the right-most col if there's no colorbar

RandSpatialCropSamples
CenterSpatialCropd

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from ericspod, Nic-Ma and rijobro October 8, 2021 09:25
@wyli
Copy link
Contributor Author

wyli commented Oct 8, 2021

couldn't make the size of subplot panels to be exactly proportional to the actual image sizes @rijobro, so I put some yticks here and I guess they are helpful.

@wyli wyli changed the title enhance transform figures 2721 - enhance transform figures Oct 8, 2021
Copy link
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! You'll need to commit the updated images to the DocImages repository of course.

For the DocImages repository, I'm thinking about keeping the history flat from the most recent release to reduce the size of the git history. So I've been amending to the previous commit and force-pushing over the top. What do you think?

@wyli
Copy link
Contributor Author

wyli commented Oct 8, 2021

Looks great, thanks! You'll need to commit the updated images to the DocImages repository of course.

For the DocImages repository, I'm thinking about keeping the history flat from the most recent release to reduce the size of the git history. So I've been amending to the previous commit and force-pushing over the top. What do you think?

sounds good, Iet me do the same for this update.

@wyli wyli merged commit 6169c5d into Project-MONAI:dev Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants