-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create transform images #3039
Create transform images #3039
Conversation
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
looks great! the only concern is the image files, could we host the images elsewhere, so that we keep the primary codebase small? |
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Could do but it would mean that we can't automate it (easily) as we can this way. Current images are 250kB, if we have 100 transforms to visualise that's 25MB. Is that too much? We could downsample by factor 2 to reduce to 6MB, and I'm sure we could play with data types to further reduce. What do you think? |
I think every time we modify the images it'll create another copy in the git history and increase the size of the |
I think it's best we store this data elsewhere, we've used gdrive and other sources before, we can do that for now at least. |
Do we have an official MONAI gdrive (or similar)? I wouldn't want to have it on my personal and then accidentally delete it. |
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Thanks, I was looking for some other options but couldn't get an idea. Creating a new GitHub repo as you did looks good to me. Further in this direction, perhaps we need a way to dynamically inject the URLs with a global variable? https://stackoverflow.com/questions/57417808/standardizing-a-link-using-a-global-variable-in-sphinx-documentation |
Hi @ericspod @wyli |
Another repository makes sense. We should keep an eye on how large its .git directory gets over time to see if it's really an issue, Github's LFS is a thing as well that's meant to help manage large files and prevent that kind of issue. We keep talking about it and never trying it. |
I used git LFS for another test base and although it's fine, I think it might be overkill for this use case. Would someone be able to review, and when happy, update the branch and enable auto-merge? |
I hope there's some sphinx plugin to handle the URLs, something like |
plt.close(fig) | ||
|
||
|
||
def create_transform_im(transform, data, ndim, update_doc=True, out_dir=None, seed=0): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SachidanandAlle mentioned that providing this utility to the users so that they can visualise the effects of the transforms for any input images. Looks like a nice feature to have cc @rijobro @Nic-Ma @ericspod
Partly addresses #2721.
Description
Automatic generation of transform example image and add to the docstring.
Status
Ready
Types of changes