Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance affinegrid to use torch backend #2969

Merged
merged 23 commits into from
Sep 20, 2021
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Sep 17, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #2231

Description

  • enhancing AffineGrid and the utilities
  • enhancing spatial cropping xforms

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the tensor-affine-grid branch from 11f0261 to fe663ab Compare September 17, 2021 16:26
wyli added 12 commits September 17, 2021 17:37
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the tensor-affine-grid branch from d14cc77 to f4b6da4 Compare September 19, 2021 14:31
@wyli
Copy link
Contributor Author

wyli commented Sep 19, 2021

/black
/integration-test

@wyli
Copy link
Contributor Author

wyli commented Sep 19, 2021

/build

  - Update test_rand_deform_grid.py
  - center_scale_crop
  - center_spatial_crop
  - rand_scale_crop
  - rand_spatial_crop
  - rand_spatial_crop_samples

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the tensor-affine-grid branch from 2f95492 to 2f1078f Compare September 19, 2021 22:49
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review September 20, 2021 06:55
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Sep 20, 2021

Hi @Nic-Ma @rijobro, I went through the transforms/croppad and transforms/spatial modules since your previous review , added non-breaking changes and tests. Please let me know if you find any issues. I'll merge this and tag a release candidate to run more tests.

@wyli wyli enabled auto-merge (squash) September 20, 2021 07:47
@wyli wyli merged commit ee202fa into Project-MONAI:dev Sep 20, 2021
@wyli wyli deleted the tensor-affine-grid branch September 20, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants